Skip to content

Conversation

@shawnbot
Copy link
Contributor

@shawnbot shawnbot commented Aug 22, 2019

Primer CSS Patch Release

Version: 📦 12.6.1
Approximate release date: 📆 August 24, 2019

🐛 Bug Fix

💅 Polish

📝 Documentation

🏠 Internal


Ship checklist

  • Update the version field in package.json
  • Update CHANGELOG.md
  • Test the release candidate version with github/github
  • Merge this PR and create a new release
  • Update github/github

For more details, see RELEASING.md.

/cc @primer/ds-core

@vercel
Copy link

vercel bot commented Aug 22, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://primer-css-git-release-1261.primer.now.sh

Remove non-ascii characters from scss files
@vercel vercel bot temporarily deployed to staging August 22, 2019 18:22 Inactive
Updating the changelog for 12.6
@vercel vercel bot temporarily deployed to staging August 22, 2019 18:23 Inactive
Fix SideNav "jumping" in Safari
@simurai simurai marked this pull request as ready for review August 23, 2019 05:34
Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good to go. 🚢

And I think we can skip "Test the release candidate version with github/github" because SelectMenu and SideNav aren't used in production yet, basically waiting for the changes in this release.

@shawnbot shawnbot merged commit fbbc8c1 into master Aug 23, 2019
@shawnbot shawnbot deleted the release-12.6.1 branch August 23, 2019 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants