Skip to content

Remove animation #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 26, 2021
Merged

Remove animation #910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4fd3fcd
remove animation
Sep 24, 2019
c43556a
Merge branch 'main' into remove-animation
jonrohan Apr 27, 2021
c134c23
Merge branch 'main' into remove-animation
jonrohan May 26, 2021
daa9c84
Removing loadable and bodymovin
jonrohan May 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions docs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
},
"dependencies": {
"@babel/preset-react": "^7.10.4",
"@loadable/component": "^5.10.2",
"@primer/components": "^17.1.0",
"@primer/gatsby-theme-doctocat": "^1.6.0",
"@primer/octicons": "^11.0.0",
Expand All @@ -36,7 +35,6 @@
"prop-types": "^15.7.2",
"raw-loader": "^4.0.2",
"react": "^16.13.1",
"react-bodymovin": "^2.0.0",
"react-dom": "^16.13.1",
"react-frame-component": "^4.1.1",
"sass-loader": "10.1.1",
Expand Down
5 changes: 1 addition & 4 deletions docs/src/@primer/gatsby-theme-doctocat/components/hero.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
import loadable from '@loadable/component'
import {Box, Heading, Text} from '@primer/components'
import {Container} from '@primer/gatsby-theme-doctocat'
import React from 'react'
import {version} from '../../../../../package.json'
import {ReactComponent as HeroIllustration} from '../../../hero-illustration.svg'

const HeroAnimation = loadable(() => import('../../../hero-animation'), {fallback: <HeroIllustration />})
Copy link
Contributor

@shawnbot shawnbot Sep 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we need to remove the loadable import from this file as well.


function Hero() {
return (
<Box bg="black" py={6}>
Expand All @@ -17,7 +14,7 @@ function Hero() {
<Text as="p" fontFamily="mono" mt={0} mb={2} color="blue.3" fontSize={2}>
v{version}
</Text>
<HeroAnimation />
<HeroIllustration />
</Container>
</Box>
)
Expand Down
16 changes: 0 additions & 16 deletions docs/src/hero-animation.js
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion docs/src/hero-animation.json
View file
Open in desktop

This file was deleted.

25 changes: 2 additions & 23 deletions docs/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1006,7 +1006,7 @@
dependencies:
regenerator-runtime "^0.13.4"

"@babel/runtime@^7.0.0", "@babel/runtime@^7.10.0", "@babel/runtime@^7.10.2", "@babel/runtime@^7.11.2", "@babel/runtime@^7.12.13", "@babel/runtime@^7.12.5", "@babel/runtime@^7.2.0", "@babel/runtime@^7.4.2", "@babel/runtime@^7.4.5", "@babel/runtime@^7.5.1", "@babel/runtime@^7.7.2", "@babel/runtime@^7.7.6", "@babel/runtime@^7.7.7", "@babel/runtime@^7.8.4", "@babel/runtime@^7.8.7":
"@babel/runtime@^7.0.0", "@babel/runtime@^7.10.0", "@babel/runtime@^7.10.2", "@babel/runtime@^7.11.2", "@babel/runtime@^7.12.13", "@babel/runtime@^7.12.5", "@babel/runtime@^7.2.0", "@babel/runtime@^7.4.2", "@babel/runtime@^7.4.5", "@babel/runtime@^7.5.1", "@babel/runtime@^7.7.2", "@babel/runtime@^7.7.6", "@babel/runtime@^7.8.4", "@babel/runtime@^7.8.7":
version "7.13.10"
resolved "https://registry.npmjs.org/@babel/runtime/-/runtime-7.13.10.tgz"
integrity sha512-4QPkjJq6Ns3V/RgpEahRk+AGfL0eO6RHHtTWoNNr5mO49G6B5+X6d6THgWEAvTrznU5xYpbAlVKRYcsCgh/Akw==
Expand Down Expand Up @@ -1468,15 +1468,6 @@
"@types/yargs" "^15.0.0"
chalk "^4.0.0"

"@loadable/component@^5.10.2":
version "5.14.1"
resolved "https://registry.npmjs.org/@loadable/component/-/component-5.14.1.tgz"
integrity sha512-UQBZfZrp1FLTf8RNhljXNHFNY4QhAA1L2+GOEeABBFre9TD0aFyQh3Sai5QxcOfy+FTbjIfti5iHaNRR7yUzEQ==
dependencies:
"@babel/runtime" "^7.7.7"
hoist-non-react-statics "^3.3.1"
react-is "^16.12.0"

"@mdx-js/mdx@^1.0.21":
version "1.6.22"
resolved "https://registry.npmjs.org/@mdx-js/mdx/-/mdx-1.6.22.tgz"
Expand Down Expand Up @@ -3611,11 +3602,6 @@ body-parser@1.19.0, body-parser@^1.19.0:
raw-body "2.4.0"
type-is "~1.6.17"

bodymovin@^4.13.0:
version "4.13.0"
resolved "https://registry.npmjs.org/bodymovin/-/bodymovin-4.13.0.tgz"
integrity sha1-Btl8ATDiM03MszvqY4E2+Ip0VAs=

bonjour@^3.5.0:
version "3.5.0"
resolved "https://registry.npmjs.org/bonjour/-/bonjour-3.5.0.tgz"
Expand Down Expand Up @@ -8061,7 +8047,7 @@ hmac-drbg@^1.0.1:
minimalistic-assert "^1.0.0"
minimalistic-crypto-utils "^1.0.1"

hoist-non-react-statics@^3.3.0, hoist-non-react-statics@^3.3.1:
hoist-non-react-statics@^3.3.0:
version "3.3.2"
resolved "https://registry.npmjs.org/hoist-non-react-statics/-/hoist-non-react-statics-3.3.2.tgz"
integrity sha512-/gGivxi8JPKWNm/W0jSmzcMPpfpPLc3dY/6GxhX2hQ9iGj3aDfklV4ET7NjKpSinLpJ5vafa9iiGIEZg10SfBw==
Expand Down Expand Up @@ -12764,13 +12750,6 @@ react-addons-text-content@^0.0.4:
resolved "https://registry.npmjs.org/react-addons-text-content/-/react-addons-text-content-0.0.4.tgz"
integrity sha1-0uJZ/clR0diQbAiQIAIQjc6HkuU=

react-bodymovin@^2.0.0:
version "2.0.0"
resolved "https://registry.npmjs.org/react-bodymovin/-/react-bodymovin-2.0.0.tgz"
integrity sha512-72MWWvPyF2Ah329+z0dVEvyNce+aiY2xOw7I9FzO8Xc15BWYvOQOnqzLTxSWjaZAdenk7e9vSanBCtB8Fqi7Cg==
dependencies:
bodymovin "^4.13.0"

react-clientside-effect@^1.2.2:
version "1.2.5"
resolved "https://registry.npmjs.org/react-clientside-effect/-/react-clientside-effect-1.2.5.tgz"
Expand Down