Skip to content

[POC] Theme abstraction #984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed

[POC] Theme abstraction #984

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
c1fcfd1
install @primer/primitives, dotmap
shawnbot Nov 15, 2019
9f106d0
very WIP: render theme-able CSS w/@primer/primitives
shawnbot Nov 15, 2019
d6240d3
lint
shawnbot Nov 15, 2019
56109a8
feat(support): add $em-spacer-map
shawnbot Nov 15, 2019
1890010
move generateThemes to separate script
shawnbot Nov 15, 2019
a961c71
generate themes from dist()
shawnbot Nov 15, 2019
581ee77
rework theme generation
shawnbot Nov 15, 2019
eeb13b8
lint
shawnbot Nov 15, 2019
f378a7b
make more variables custom props
shawnbot Nov 15, 2019
6c3ada7
feat(support): add $border-radius-2
shawnbot Nov 15, 2019
7f3449c
add border-radius-2, body-font-size, body-line-height
shawnbot Nov 15, 2019
31e5c24
"light" -> "default" theme
shawnbot Nov 16, 2019
da7ff50
Merge branch 'master' into custom-properties
simurai Dec 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat(support): add $border-radius-2
  • Loading branch information
@shawnbot
shawnbot committed Nov 15, 2019
commit 6c3ada7b49e2386d260288fc83516b34f782561c
2 changes: 1 addition & 1 deletion src/select-menu/select-menu.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
flex-direction: column;
background-color: $bg-gray;
// stylelint-disable-next-line primer/borders
border-radius: $border-radius * 2;
border-radius: $border-radius-2;
// stylelint-disable-next-line primer/box-shadow
box-shadow: 0 0 18px rgba(0, 0, 0, 0.4);
animation: SelectMenu-modal-animation 0.12s cubic-bezier(0, 0.1, 0.1, 1) backwards;
Expand Down
1 change: 1 addition & 0 deletions src/support/variables/misc.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ $border-color: $border-gray !default;
$border-style: solid !default;
$border: $border-width $border-color $border-style !default;
$border-radius: 3px !default;
$border-radius-2: $border-radius * 2 !default;

// Box shadow
$box-shadow: 0 1px 1px rgba($black, 0.1) !default;
Expand Down
4 changes: 2 additions & 2 deletions src/utilities/borders.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
/* Add a border-radius to all corners */
.rounded#{$variant}-1 { border-radius: $border-radius !important; }
/* Add a 2x border-radius to all corners */
.rounded#{$variant}-2 { border-radius: $border-radius * 2 !important; }
.rounded#{$variant}-2 { border-radius: $border-radius-2 !important; }

@each $edge, $corners in $edges {
.rounded#{$variant}-#{$edge}-0 {
Expand All @@ -62,7 +62,7 @@

.rounded#{$variant}-#{$edge}-2 {
@each $corner in $corners {
border-#{$corner}-radius: $border-radius * 2 !important;
border-#{$corner}-radius: $border-radius-2 !important;
}
}
}
Expand Down