Skip to content

Conversation

@simurai
Copy link
Contributor

@simurai simurai commented Dec 12, 2019

This adds responsive variants to the line-height utilities.

  • .lh-[sm|md|lg|xl]-condensed-ultra
  • .lh-[sm|md|lg|xl]-condensed
  • .lh-[sm|md|lg|xl]-default
  • .lh-[sm|md|lg|xl]-0

rlh

Bundle size changes

┌─────────────────────┬───────────┬───────┬───────────┬──────────┬──────────┬───────────┬──────────────────────────────┐
│ name                │ selectors │     ± │ gzip size │        ± │ raw size │         ± │ path                         │
├─────────────────────┼───────────┼───────┼───────────┼──────────┼──────────┼───────────┼──────────────────────────────┤
│ primer              │      3386 │  + 16 │   27.47 K │   + 90 B │ 172.64 K │   + 786 B │ dist/primer.css              │
│ core                │      2254 │  + 16 │   17.95 K │   + 92 B │ 114.15 K │   + 786 B │ dist/core.css                │
│ utilities           │      1381 │  + 16 │    8.75 K │   + 91 B │  66.76 K │   + 786 B │ dist/utilities.css           │

+ 90 B gzipped should be fine. 👍


Closes #993

@vercel
Copy link

vercel bot commented Dec 12, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/primer/primer-css/cew21qeaa
🌍 Preview: https://primer-css-git-responsive-line-height.primer.now.sh

@simurai simurai marked this pull request as ready for review December 12, 2019 07:38
@skullface
Copy link
Contributor

😍 Thank you @simurai!

@simurai simurai changed the base branch from master to release-14.1.0 December 17, 2019 00:40
@simurai simurai requested a review from jonrohan December 17, 2019 00:53
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems useful, and doesn't add too much bloat. I'll approve. 👍

@simurai simurai merged commit 1aab8e0 into release-14.1.0 Dec 17, 2019
@simurai simurai deleted the responsive-line-height branch December 17, 2019 11:00
@simurai simurai mentioned this pull request Dec 17, 2019
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants