Warn on invalid @value
definitions
#57
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just noticed a flaw with my previous PR #56 -
RegExp.prototype.exec
will return null if no match is found. Previously this wouldn't cause an error since thewhile
statement would skip ifmatches
was null. Now it will throw aTypeError: object null is not iterable
when destructuring the result.This PR prevents this error, and instead emits a postcss warning if the
@value
statement couldn't be parsed. This matches the behavior ofpostcss-modules-values
as described in this test.