Skip to content

browserOverride should accept a browser instance instead of a brittle config object #4

Closed
@bartveneman

Description

@bartveneman

ATM, browserOverride is a complex piece of if-statements and a combination of fields, but actually it should accept a fully configured browser instance.

Example:

const browser = puppeteer.launch(browserOptions)
const css = extractCss(url, {browserOverride: browser})

We should build in some sanity checks that the browser has at least the correct interface in regard to the following methods:

  • newPage()
  • close()

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions