make it possible to pass puppeteer launch options #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thanks for looking at this. Your use-case looks pretty valid to me. Do you think we should allow all options to be passed, or maybe only a subset? Additionally, would you mind updating the readme with this new option as well? |
bartveneman
requested changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to pass puppeteer launch options, as it is necessary to solve deploy problems like this one for example
All the possible options can be seen here
https://github.com/puppeteer/puppeteer/blob/main/docs/api.md#puppeteerlaunchoptions
(Thanks for the lib, it is really helpful)