-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add Column Shuffling #400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Column Shuffling #400
Conversation
Created a class structure allowing developers to shuffle around columns in a grid allowing, for example, to put the column that would be on the left by default, to the right and the column that would be on the the right by default on the left. This adversely allows the column that is now on the right, to collapse to the top above the column that is now on the right. This uses the same syntax as the grid system. The default shuffle (non responsive) looks like `left-1` or `right-2` where right and left refer to which side the column will shuffle from and the number represents how many columns it will shuffle over. The responsive syntax for shuffling is also like the grid system, so `left-sm-1` would apply when the viewport is greater than 35.5em (default).
|
Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄 |
|
As far as I can tell, the only reason it failed the build test was because of "Adjoining Classes" which is only an IE6 issue... and do you really care about IE6 anymore? I kinda feel like adjoining classes are important to use here. |
Fixed the responsive bug where, say `left-sm-1` wouldn't take hold for the md, lg, or xl viewport sizes.
|
CLA is valid! |
Fixed the issue where some calls were getting overridden by the improper call due to Hierarchy issues.
|
I'll be taking a closer look at this PR in the coming weeks. We hear you and appreciate the input. Also glad to see you got the CLA worked out. I agree, IE6 is not a concern for Pure, and therefore adjoining classes perhaps should be allowed. |
|
Thanks for the update James, really appreciate it! Let me know if there is anything I need to do. |
|
Zach, there are a few things we need to work on with this PR-- and even then, I'm not promising I'll agree we should bundle it with Pure. (Perhaps it could be included as an optional file if folks want to create their own rollups.) In any case, here are the problems we need to address now:
|
…ctors, then one file for each media selector) to pass Internet Explorer selector test
|
James, I added all of the changes that you asked me to do, and they are in the most recent commit |
|
I just want throw some love out for the pure community, was just looking for this on a build & spent about 2mins looking before yay! |
|
I have a general git question, this issue along with mobile collapsible nav get merged into a project, where does one find that repo? |
|
@vikrambabu Glad I was able to help you out! The only issue with this right now is that it goes over IE's 4000 selector limit. I can easily fix this by removing some grid sizes, but I wasn't sure which to remove. (The 24 grid size is a selector hog.) This issue and the mobile collapsible nav are two different repos. Mine for column shuffling can be found here: https://github.com/ZachCase/pure The Mobile Collapsible Nav issues looks to have been fixed by the Pure dev team actually, and they stated that a new release with the fix is "imminent". |
|
@vikrambabu As Zach says, the release of Pure 0.6.0 is imminent. As early as tomorrow I hope to have it out in Release Candidate form; you'll be able to easily play with it and see how you like it, and you'll be able to see the new examples on the staging server. |
|
Thanks @zachcase & @jamesalley, couldn't come at a better time as we're looking to launch sometime next week! |
|
I do not believe this will be something we pull in by default in Pure. I think its best left in user land as it adds more weight and maintenance to the library. |
Created a class structure allowing developers to shuffle around columns
in a grid allowing, for example, to put the column that would be on the
left by default, to the right and the column that would be on the the
right by default on the left. This adversely allows the column that is
now on the right, to collapse to the top above the column that is now on
the right.
This uses the same syntax as the grid system. The default shuffle (non
responsive) looks like
left-1orright-2where right and left referto which side the column will shuffle from and the number represents how
many columns it will shuffle over.
The responsive syntax for shuffling is also like the grid system, so
left-sm-1would apply when theviewport is greater than 35.5em (default).