Add xxl (1920px) media query#965
Merged
redonkulus merged 1 commit intopure-css:masterfrom Mar 14, 2022
Merged
Conversation
Contributor
|
Makes sense, thanks for the PR! |
Contributor
|
Released in v2.1.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there 👋
FullHD screens aren't large anymore with 4K becoming the norm.
Hence it seems appropriate to include one more media query for screens larger than 1920px by default (meaning without having to use grunt or the rework plugin). Additionally, people who use the CDN will get to use it too.
This is my first pull request so if anything is missing or unclear please tell me.
PS: The Yahoo CLA just shows an error page so I couldn't sign it.