Merged
Conversation
added 2 commits
October 18, 2017 16:24
Contributor
Author
|
@ractoon, any feedback? |
Owner
|
Hi @trevorloflin, Thanks for the pull request. This looks great! I'd just like to address this and a couple other items this week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the
minDisplayCutoffandmaxDisplayCutoffoptions. When set, these hide the counter when the current count is sufficiently far from the limits. E.g. if themaxoption is set to 1000 and themaxDisplayCutoffoption is set to 100, the counter will only appear if the user enters at least 900 characters. Conversely if theminoption is set to 1000 and theminDisplayCutoffis set to 100, the counter will only appear if the user has entered 1100 characters or less. This can create a less obtrusive experience for the user.Feel free to make any tweaks necessary to bring it into line with the project.