Introduce modern-normalize for postcss and sass installs
#139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds [modern-normalize][] to `postcss` and `sass` installation scripts in an effort to improve the developer experience. This is consistent with the existing decision to include [autoprefixer][] with the `postcss` installation script. We chose [modern-normalize][] over [Normalize.css][] due to that fact that it is actively maintained and is used in [Tailwind][]. [modern-normalize]: https://github.com/sindresorhus/modern-normalize [autoprefixer]: https://github.com/postcss/autoprefixer [Normalize.css]: https://github.com/csstools/normalize.css [Tailwind]: https://tailwindcss.com/docs/preflight
|
I'd rather be going in the other direction and consider whether we still need autoprefixer. This needs to be an absolute minimal install that people can then take further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds modern-normalize to
postcssandsassinstallation scripts in an effort to improve the developer experience.This is consistent with the existing decision to include autoprefixer with the
postcssinstallation script.We chose modern-normalize over Normalize.css due to that fact that it is actively maintained and is used in Tailwind.
How to review this pull-request
Create a new rails app without specifying a
--cssoption:Add the gem referencing this fork.
Run the installation script for either
postcssorsass.Confirm the styles are compiled to
app/assets/builds/application.css