Skip to content

Allow NPM use for install/build #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

ksol
Copy link

@ksol ksol commented Jan 5, 2024

Related to #138.

rails/jsbundling-rails#179 was merged, so let's align the behaviors

@ksylvest
Copy link
Contributor

ksylvest commented Jan 5, 2024

Flagging since I believe this introduces a subtle bug when having bun installed but a package-lock.json file (attempts to use bun). I've moved over a fix:

#144

Also - opened a PR for jsbundling-rails here: rails/jsbundling-rails#180

@ksol
Copy link
Author

ksol commented Jan 6, 2024

that's indeed better and more readable, I'll close this one :) Thanks!

@ksol ksol closed this Jan 6, 2024
@ksol ksol deleted the feat/task-npm-support branch January 9, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants