Fix Bootsrap install when there is no assets.rb

[kivanio]

Fix rails/rails#44597

[Edouard-chin]

I think the fix should be in rails/rails, deleting the assets.rb file when using propshaft is initially wrong. Now that Rails supports two asset pipeline out of the box (sprockets/propshaft) we basically need to handle those two cases:

• When an application is using sprockets -> Delete all files specific to propshaft (there is none right now)
• When an application is using propshaft -> Delete all files specific to sprockets (manifest.js I think is the only one)

The code generated in the assets.rb initializer is compatible with both propshaft and sprockets and there is no reason to delete it IMO.

[Edouard-chin]

Giving this a second thought, it also make sense to check if the assets.rb file exists

[Edouard-chin]

Maybe if it doesn't exist, we can do the same as below and output what to do ?

[kivanio]

What is most correct to say:

something like:

Add Rails.application.config.assets.paths << Rails.root.join("node_modules/bootstrap-icons/font") to your entry point Assets file

or something like

Create config/initializers/assets.rb and add Add Rails.application.config.assets.paths << Rails.root.join("node_modules/bootstrap-icons/font") there

If it is second so we should create the file with correct content inside.
Right?

[Edouard-chin]

What do you think about

Add Rails.application.config.assets.paths << Rails.root.join("node_modules/bootstrap-icons/font") in your assets configuration file (by convention in 'config/initializers/assets.rb')

[kivanio]

Done

[viktorianer]

And why just not create this file config/initializers/assets.rb, if it not exists?

But, it is fixed with rails/rails#44615.

[kivanio]

@Edouard-chin
I do not know how propshaft works so I assumed assets.rb was not necessary but if it is I think you are right.
It need to be fixed in both places.

[dhh]

Fixed via rails/rails#44615