Fix for foreman existence test in rbenv installs. #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because rbenv uses shims, the existence of foreman in any gemset will result in this test passing (indicating that the tool is available), whether it's in the current gemset or not. This test, courtesy of @t27duck, ensures that foreman is actually operable in the current context.
Contributor
|
@MrJoy This should probably be done in |
Contributor
Author
|
@t27duck Ah! Good call! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #87:
Because
rbenvuses shims, the existence offoremanin any gemset will result in this test passing (indicating that the tool is available), whether it's in the current gemset or not.This test, courtesy of @t27duck, ensures that
foremanis actually operable in the current context.