Add #to_s method to rails version

[robertomiranda]

now Rails.version returns an instance of Gem::Version
cc @rafaelfranca
ref rails/rails#8501, https://travis-ci.org/rails/rails/jobs/5750326

[rafaelfranca]

Thank you

[carlosantoniodasilva]

I wonder how many gems will have to add a to_s 😄

[rafaelfranca]

Good question. Maybe if we have a lot of gems relaying on this behavior we
should revert this change.
On Mar 24, 2013 12:35 AM, "Carlos Antonio da Silva" <
notifications@github.com> wrote:

I wonder how many gems will have to add a to_s [image: 😄]

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/117#issuecomment-15350863
.

[indirect]

Depends on whether the gems interpolate it or not, I guess. :\

On Mar 23, 2013, at 8:37 PM, Rafael Mendonça França notifications@github.com wrote:

Good question. Maybe if we have a lot of gems relaying on this behavior we
should revert this change.
On Mar 24, 2013 12:35 AM, "Carlos Antonio da Silva" <
notifications@github.com> wrote:

I wonder how many gems will have to add a to_s [image: 😄]

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/117#issuecomment-15350863
.

—
Reply to this email directly or view it on GitHub.

[tamird]

Nitpicking a bit, but this is not the right way to do it.

2.0.0p0 :020 > '4.0.0.beta1' > '4.0.0.1'
 => true
2.0.0p0 :021 > Gem::Version.new('4.0.0.beta1') > Gem::Version.new('4.0.0.1')
 => false

String comparison semantics are different from Gem::Version comparison semantics.

[indirect]

It was more about getting it to not crash at the moment. Doing it right would be a Gem::Requirement:

Gem::Requirement.new(">= 4.0.0.beta").satisfied_by?(Rails.version)

[tamird]

Ah, fair enough. #to_s is probably the only way to make things compatible for now, short of going to Rails::VERSION::<segment> =/

[guilleiguaran]

can we get a new version of jquery-rails with this patch, please? 😁

[robertomiranda]

@guilleiguaran would be nice 👍

[ai]

Waiting for release with this fix.