Closed
Conversation
added 3 commits
June 3, 2011 14:09
… ujs - but i didnt include any other versions yet
Member
|
I think it makes sense to lock individual versions of jquery-rails to individual versions of jQuery, especially given that in Rails 3.1 there is not a generator to run. The files are just be used directly out of the gem with no other configuration required. Thanks for the submission, though! |
Author
|
sounds reasonable :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i added options for jquery, jquery-ui, jquery-ujs versions to the generator. it's now possibile to add different versions of jquery to ../assets/jquery//jquery.js - not sure if this makes to much sense to merge in upstream (and also i didn't include any other versions), but thought i send a pull request anyway, and leave it to you.