Skip to content

support for disable classes added.#209

Closed
lxsameer wants to merge 1 commit intorails:masterfrom
Yellowen:master
Closed

support for disable classes added.#209
lxsameer wants to merge 1 commit intorails:masterfrom
Yellowen:master

Conversation

@lxsameer
Copy link

With this change each element that contains the data-disable-with
attribute can provides an attribute called data-disable-class
which would be a string of classes to be added to the element
after the element disabled. For example using this feature it
would be possible to pass disabled css class to a bootstrap button.

With this change each element that contains the `data-disable-with`
attribute can provides an attribute called `data-disable-class`
which would be a string of classes to be added to the element
after the element disabled. For example using this feature it
would be possible to pass `disabled` css class to a bootstrap button.
@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @lucasmazza (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rafaelfranca
Copy link
Member

Thank you for the pull request but I don't think it is something useful for a lot of applications. You can define your own functions in your application enabling the behavior your want.

@lxsameer
Copy link
Author

ok thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants