Refactored code#106

Closed

dcrec1 wants to merge 17 commits intorails:masterfrom

Commits on Feb 20, 2011

refactored element.attr('data-x') to element.data('x')
dcrec1
committed
removed optional operator
dcrec1
committed
refactored commented code to a function
dcrec1
committed
dryed .live('x.rails') with .on(x)
dcrec1
committed
dryed 's ajax:beforeSend and ajax:complete
dcrec1
committed
removed forgotten comment
dcrec1
committed
changed return false in favor of event.preventDefault, as what we really want is to prevent the default event of the elements and not to stop the event chain
dcrec1
committed
dryed code that execute an action if the event is allowed
dcrec1
committed
removed some ifs, instead of selecting a lot of elements and then verifying the kind to know what behaviour to apply, select the elements of an specific kind and then apply the behaviour
dcrec1
committed
moved event.preventDefault to handleRemote and handleMethod, as this go together always
dcrec1
committed
dryied code
dcrec1
committed
refactored disableFormElements and enableFormElements, removed .each in favor of .val
dcrec1
committed
dryed code by chained two methods
dcrec1
committed
refactored code that validates if required fields are missing
dcrec1
committed
removed if by dividing handleRemote into handleRemoteForm and handleRemoteLink, as each one has a different behaviour
dcrec1
committed
refactored code, validating if the form is ok is part of handleRemoteForm
dcrec1
committed
dryed some code
dcrec1
committed