Merged
Conversation
Member
Author
|
Ugh, I cannot get the spacing right on the rails.js file. What kind of tabs are being used for rails.js, and why is the tab spacing different between the rails.js and the qunit tests? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed behavior for IE, in which remote form was being submitted, even if the submit button had
data-confirmand was cancelled. See this comment for cause and explanation.I didn't add any tests because this was an IE-only bug. I'm sure I could write a failing test-case which could be observed if the test suite is run in IE, but for the most part, I just considered it a success that I implemented this fix without making any of the existing tests fail. Let me know if this is essential, and I'll figure out a test.