Closed
Conversation
Author
|
I've now run into the situation where event.preventDefault() on a form fails to work. Took me a while to figure out this code was responsible. So i've changed my mind that this is a good idea. |
|
@jpzwarte, could you go into greater detail over why I'd love to have this functionality. For now I'm disabling UJS for a specific subset of links and providing my own handler: https://gist.github.com/4485846 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've redone the async-confirm branch changes on top of master. In the last 4 projects we've done, we've used a non-native confirm dialog every single time. Any change on whether or not to merge this with master? Tests still all pass.
Here's an example using async confirm: https://gist.github.com/3878172