Skip to content

There is still an issue in jQuery 1.4.4#45

Closed
art-orlov wants to merge 5 commits intorails:masterfrom
art-orlov:master
Closed

There is still an issue in jQuery 1.4.4#45
art-orlov wants to merge 5 commits intorails:masterfrom
art-orlov:master

Conversation

@art-orlov
Copy link

Still have to fix rails.js to work in our case. We have links with "date-confirm" and "data-method" simultaneously. Such links don't with in jQuery 1.4.3 - 1.4.4 without fix been pulled. Not sure if there are any issues with form.submit, just added it in case previous time.

@art-orlov
Copy link
Author

Sorry, line endings in your version doesn't seem to be linux variant and i updated them.

@neerajsingh0101
Copy link

Can you produce a better diff. I can't see what has changed in the pull request.

@art-orlov
Copy link
Author

We have links looking like:
<%= link_to 'Delete Profile', path_helper_here, :confirm => 'Are you sure?', :method => :delete %>

Links are shown when actions popup is opened. If you open popup, close and open again only confirm callback works. That's because of incorrect handling of pupup close. It makes $(document).unbind('click') without specifying handler pointer.

I guess that live/delegate jQuery tricks are made using event propagation and catching them on level of document/delegate node. So popup closing code just cleared callback set by rails.js using live trick.

So i think that we can close this request without applying changes. It appears to be jQuery issues.
Only callbacks attached to node itself should be cleared, but internal live-related things should be kept.

@art-orlov
Copy link
Author

I added ticket in jQuery bug tracker: http://bugs.jquery.com/ticket/7520

@neerajsingh0101
Copy link

As per request closing it.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants