Skip to content

fixed beforeSend callback#63

Closed
jerrett wants to merge 2 commits intorails:masterfrom
jerrett:master
Closed

fixed beforeSend callback#63
jerrett wants to merge 2 commits intorails:masterfrom
jerrett:master

Conversation

@jerrett
Copy link

@jerrett jerrett commented Dec 14, 2010

Currently the event beforeSend is triggered, but the code is listening for before meaning it never gets hit, and buttons get blanked out and broken when data-disable-with is used

@mislav
Copy link
Member

mislav commented Dec 30, 2010

Hello, in fbbefa0 we had a little discussion and we're going to get to beforeSend issues soon, including your fix. Thanks

@iamvery
Copy link

iamvery commented Dec 30, 2010

I am also quite interested in this. I was having issues with my beforeSend callback not being called, even when using your ajaxSetup method of "initializing" a global beforeSend callback. Anyway, take a look at this fork. Maybe d94dc1d4e3d4bed0cc2588c44a6ed6b5d6b3ac88 is helpful?

@mislav
Copy link
Member

mislav commented Dec 30, 2010

It doesn't seem you are very confident about what you're doing here. Your "improvement" only seems to complicate things more, but you were right that original jQ "beforeSend" callback has two parameters.

We'll get to the bottom of this. Us maintainers have to have an internal chat

@iamvery
Copy link

iamvery commented Dec 30, 2010

No worries, I think I haven't had time to fully understand the root issue at hand. I'm looking forward to seeing where this goes. Just trying to be helpful :P

@mislav
Copy link
Member

mislav commented Jan 7, 2011

test that "ajax:beforeSend" bubbles and can cancel the ajax request

closed by 0ff66c4, #71, #73

JangoSteve added a commit to JangoSteve/jquery-ujs that referenced this pull request Aug 13, 2012
@JangoSteve
Copy link
Member

Oops, disregard that last commit, was meant to reference issue 63 jquery-rails.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants