Closed
Conversation
|
I had introduced that line sometime back. After thinking about it , I decided to remove that line. In this way whatever value browser sets will be sent to server rather than rails.js setting the value. Thanks for the pull request. And sorry I should have taken that decision earlier. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rails returns "406 Not Acceptable" when the response type in an ajax call is different from "text/javascript" (e.g. json). This is because the Accept header is overwritten in Firefox when setting "Accept" to "text/javascript" as the existing code does before invoking the ajax request. (This bug does not appear in other browsers because they prepend "/" to the Accept header field.)
I've fixed it by setting the Accept field to "/".