Skip to content

Tailwind scaffold template is out of sync with rails/rails ERB scaffold template #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yshmarov opened this issue Mar 24, 2024 · 2 comments · Fixed by #357
Closed

Tailwind scaffold template is out of sync with rails/rails ERB scaffold template #341

yshmarov opened this issue Mar 24, 2024 · 2 comments · Fixed by #357
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@yshmarov
Copy link
Contributor

https://github.com/rails/tailwindcss-rails/blob/main/lib/generators/tailwindcss/scaffold/templates/index.html.erb.tt is out of sync with https://github.com/rails/rails/blob/main/railties/lib/rails/generators/erb/scaffold/templates/index.html.erb.tt, namely it's missing the <% content_for :title, "New event" %>

Should template files be kept in sync (except the tailwind classes)?

Screenshot 2024-03-24 at 21 55 11
@flavorjones
Copy link
Member

@yshmarov Thanks for spotting that! If you have the time to submit a PR I would be happy to merge it. If not, please let me know and I can fix it later this week.

@flavorjones
Copy link
Member

Looking at the changes to rails templates since 2021, there are a few changes that should probably be carried over to this gem. I'm not going to do this work, but would welcome anyone from the community who would like to submit a PR.

I think the set of changes that should be looked at is limited to:

@flavorjones flavorjones added help wanted Extra attention is needed good first issue Good for newcomers labels Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants