Simplify "Building for testing" [merge after Rails 7.1] #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that rails/rails#46664 is merged, we can simplify the testing instructions. Technically these instructions aren't true until Rails 7.1, so I'm happy to leave the PR open until then if that's preferred.
ghiculescu
added a commit
to ghiculescu/cssbundling-rails
that referenced
this pull request
Jan 10, 2023
ghiculescu
added a commit
to ghiculescu/jsbundling-rails
that referenced
this pull request
Jan 10, 2023
This was referenced Jan 10, 2023
|
🥳 Congrats on making that change upstream! I still feel like people are slow enough to upgrade that it may make sense to keep some version of this explanation around for a while. WDYT? |
|
Yes I agree, I mostly didn’t want to forget about it. We can just keep this PR open for a while. Or are you thinking we have “if you use Rails 7.1, do X, otherwise do Y” style instructions? |
|
I meant, let's leave this unmerged until Rails 7.1 ships. |
dhh
pushed a commit
to rails/jsbundling-rails
that referenced
this pull request
Jun 18, 2023
smartech7
pushed a commit
to smartech7/ruby-css-bundling
that referenced
this pull request
Aug 4, 2023
smartech7
pushed a commit
to smartech7/ruby-js-bundling
that referenced
this pull request
Aug 4, 2023
|
@flavorjones is this okay to merge now? |
|
@ghiculescu Thank you for the reminder! Merging. |
bobryk729
added a commit
to bobryk729/cssbundling-rails
that referenced
this pull request
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that rails/rails#46664 is merged, we can simplify the testing instructions.
Technically these instructions aren't true until Rails 7.1, so I'm happy to leave the PR open until then if that's preferred.