Skip to content

Correctly purge decimal spacing classes #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2021
Merged

Correctly purge decimal spacing classes #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/tailwindcss/purger.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
class Tailwindcss::Purger
CLASS_NAME_PATTERN = /([:A-Za-z0-9_-]+[\.]*[\\\/:A-Za-z0-9_-]*)/
CLASS_NAME_PATTERN = /([:A-Za-z0-9_-]+[\.\\\/:A-Za-z0-9_-]*)/
OPENING_SELECTOR_PATTERN = /\..*\{/
CLOSING_SELECTOR_PATTERN = /\s*\}/
NEWLINE = "\n"
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/simple.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
<div class="max-w-7xl mx-auto px-4 sm:px-6 lg:px-8 translate-x-1/2">
<div class="max-w-7xl mx-auto my-1.5 px-4 sm:px-6 lg:px-8 sm:py-0.5 translate-x-1/2">
</div>
18 changes: 11 additions & 7 deletions test/purger_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@

class Tailwindcss::PurgerTest < ActiveSupport::TestCase
test "extract class names from string" do
assert_equal %w[ div class max-w-7xl mx-auto px-4 sm:px-6 lg:px-8 translate-x-1/2 ].sort,
Tailwindcss::Purger.extract_class_names(%(<div class="max-w-7xl mx-auto px-4 sm:px-6 lg:px-8 translate-x-1/2">))
assert_equal %w[ div class max-w-7xl mx-auto my-1.5 px-4 sm:px-6 lg:px-8 sm:py-0.5 translate-x-1/2 ].sort,
Tailwindcss::Purger.extract_class_names(%(<div class="max-w-7xl mx-auto my-1.5 px-4 sm:px-6 lg:px-8 sm:py-0.5 translate-x-1/2">))
end

test "extract class names from files" do
assert_equal %w[ div class max-w-7xl mx-auto px-4 sm:px-6 lg:px-8 translate-x-1/2 ].sort,
assert_equal %w[ div class max-w-7xl mx-auto my-1.5 px-4 sm:px-6 lg:px-8 sm:py-0.5 translate-x-1/2 ].sort,
Tailwindcss::Purger.extract_class_names_from(Pathname.new(__dir__).join("fixtures/simple.html.erb"))
end

Expand All @@ -20,6 +20,8 @@ class Tailwindcss::PurgerTest < ActiveSupport::TestCase
assert purged =~ /.sm\\:px-6 \{/
assert purged =~ /.translate-x-1\\\/2 \{/
assert purged =~ /.mt-10 \{/
assert purged =~ /.my-1\\.5 \{/
assert purged =~ /.sm\\:py-0\\.5 \{/
end

test "purge shouldn't remove hover or focus classes" do
Expand All @@ -30,9 +32,7 @@ class Tailwindcss::PurgerTest < ActiveSupport::TestCase
end

test "purge shouldn't remove placeholder selectors" do
purged = Tailwindcss::Purger.purge \
Pathname.new(__FILE__).join("../../app/assets/stylesheets/tailwind.css").read,
keeping_class_names_from_files: Pathname(__dir__).join("fixtures/placeholders.html.erb")
purged = purged_tailwind_from Pathname(__dir__).join("fixtures/placeholders.html.erb")

assert purged =~ /.placeholder-transparent\:\:-moz-placeholder \{/
assert purged =~ /.placeholder-transparent\:-ms-input-placeholder \{/
Expand All @@ -41,8 +41,12 @@ class Tailwindcss::PurgerTest < ActiveSupport::TestCase

private
def purged_tailwind_from_fixtures
purged_tailwind_from Pathname(__dir__).glob("fixtures/*.html.erb")
end

def purged_tailwind_from files
Tailwindcss::Purger.purge \
Pathname.new(__FILE__).join("../../app/assets/stylesheets/tailwind.css").read,
keeping_class_names_from_files: Pathname(__dir__).glob("fixtures/*.html.erb")
keeping_class_names_from_files: files
end
end