Webpacker: Basic purging patterns #40
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR configures Tailwind purging with basic rails app needs. Developers can easily change this down the road, but this should serve as a good starting point.
codingluke
reviewed
Feb 8, 2021
|
@dhh wdyt? |
ghiculescu
reviewed
Feb 24, 2021
| './app/javascript/**/*.js', | ||
| ], | ||
| }, | ||
| darkMode: false, // or 'media' or 'class' |
There was a problem hiding this comment.
unrelated to this PR, but should this be updated to match https://github.com/rails/tailwindcss-rails/blob/main/tailwind.config.js#L4 ?
ghiculescu
reviewed
Feb 24, 2021
Comment on lines
+6
to
+7
| './**/*.html.erb', | ||
| './app/helpers/**/*.rb', |
There was a problem hiding this comment.
Suggested change
| './**/*.html.erb', | |
| './app/helpers/**/*.rb', | |
| './app/views/**/*.*, | |
| './app/helpers/**/*.rb', |
IMO this should match the compressor: https://github.com/rails/tailwindcss-rails/blob/main/lib/tailwindcss/compressor.rb#L14, so that either way you use this gem you get the same outcome.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR configures Tailwind purging with basic rails app needs.
Developers can easily change this down the road, but this should serve
as a good starting point.
On bare-bones rails new (running this in development env):
Before
After
ps
In real-world app difference will be smaller, since there is less to purge :)