Skip to content

Unbreak support for tailwind v4. #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Unbreak support for v4 input file.
Reverts part of 6e828eb but adds to test coverage now that I
understand the other changes v4 requires.
  • Loading branch information
flavorjones committed Oct 18, 2024
commit 1acd6c56e12d5c1e51c54fe0ca8e3552eb87ecc9
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## next / unreleased

* Add experimental support for Tailwind CSS v4. (#420) @flavorjones
* Add experimental support for Tailwind CSS v4. (#420, #423) @flavorjones


## v3.0.0
Expand Down
15 changes: 3 additions & 12 deletions lib/tailwindcss/commands.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,23 +3,14 @@
module Tailwindcss
module Commands
class << self
def tailwindcss_version
Tailwindcss::Ruby::VERSION
end

def compile_command(debug: false, **kwargs)
command = [
Tailwindcss::Ruby.executable(**kwargs),
"-o", Rails.root.join("app/assets/builds/tailwind.css").to_s
"-i", Rails.root.join("app/assets/stylesheets/application.tailwind.css").to_s,
"-o", Rails.root.join("app/assets/builds/tailwind.css").to_s,
"-c", Rails.root.join("config/tailwind.config.js").to_s,
]

unless tailwindcss_version >= "4.0"
command += [
"-i", Rails.root.join("app/assets/stylesheets/application.tailwind.css").to_s,
"-c", Rails.root.join("config/tailwind.config.js").to_s,
]
end

command << "--minify" unless (debug || rails_css_compressor?)

postcss_path = Rails.root.join("config/postcss.config.js")
Expand Down
18 changes: 18 additions & 0 deletions test/integration/user_journey_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,12 @@ bundle install
bundle show --paths
bundle binstubs --all

if bundle show | fgrep tailwindcss-ruby | fgrep -q "(4." ; then
TAILWIND4=1
else
TAILWIND4=0
fi

# install tailwindcss
bin/rails tailwindcss:install

Expand All @@ -45,6 +51,13 @@ task :still_here do
end
EOF

if [[ $TAILWIND4 = 1 ]] ; then
cat > app/assets/stylesheets/application.tailwind.css <<EOF
@import "tailwindcss";
@theme { --color-special: #abc12399; }
EOF
fi

bin/rails tailwindcss:build still_here | grep "Rake process did not exit early"

if [[ $(rails -v) > "Rails 8.0.0.beta" ]] ; then
Expand All @@ -61,4 +74,9 @@ grep -q "Show this post" app/views/posts/index.html.erb
bin/rails tailwindcss:build[verbose]
grep -q "py-2" app/assets/builds/tailwind.css

if [[ $TAILWIND4 = 1 ]] ; then
# TEST: contents include application.tailwind.css
grep -q "#abc12399" app/assets/builds/tailwind.css
fi

echo "OK"
29 changes: 7 additions & 22 deletions test/lib/tailwindcss/commands_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -9,29 +9,14 @@ def setup
@executable = Tailwindcss::Ruby.executable
end

test ".compile_command with tailwindcss v3" do
test ".compile_command" do
Rails.stub(:root, File) do # Rails.root won't work in this test suite
Tailwindcss::Commands.stub(:tailwindcss_version, "3.4.13") do
actual = Tailwindcss::Commands.compile_command
assert_kind_of(Array, actual)
assert_equal(executable, actual.first)
assert_includes(actual, "-i")
assert_includes(actual, "-c")
assert_includes(actual, "-o")
end
end
end

test ".compile_command with tailwindcss v4" do
Rails.stub(:root, File) do # Rails.root won't work in this test suite
Tailwindcss::Commands.stub(:tailwindcss_version, "4.0.0") do
actual = Tailwindcss::Commands.compile_command
assert_kind_of(Array, actual)
assert_equal(executable, actual.first)
refute_includes(actual, "-i")
refute_includes(actual, "-c")
assert_includes(actual, "-o")
end
actual = Tailwindcss::Commands.compile_command
assert_kind_of(Array, actual)
assert_equal(executable, actual.first)
assert_includes(actual, "-i")
assert_includes(actual, "-c")
assert_includes(actual, "-o")
end
end

Expand Down