Fix "Update Tailwind" action #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`tailwindcss-cli build` chokes on `require('tailwindcss/defaultTheme')`
in tailwind.config.js added by 53089c1.
Example failure: https://github.com/rails/tailwindcss-rails/runs/1725407564.
`tailwind build`, which is invoked by `yarn build`, handles this
properly. Running `yarn upgrade tailwindcss` beforehand ensures that
the `tailwind build` command is installed, and updates the Tailwind
version in yarn.lock to match the built tailwind.css.
jonathanhefner
added a commit
to jonathanhefner/tailwindcss-rails
that referenced
this pull request
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tailwindcss-cli buildchokes onrequire('tailwindcss/defaultTheme')intailwind.config.jsadded by 53089c1. Example failure: https://github.com/rails/tailwindcss-rails/runs/1725407564.tailwind build, which is invoked byyarn build, handles this properly. Runningyarn upgrade tailwindcssbeforehand ensures that thetailwind buildcommand is installed, and updates the Tailwind version inyarn.lockto match the builttailwind.css.Example success after this change: https://github.com/jonathanhefner/tailwindcss-rails/runs/1954932857. Resulting commit: jonathanhefner@9dd1367.