Skip sprockets initializers for apps that don't use sprockets #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This gem has now doubled down on being a solutions specifically for sprockets based apps, so I don't think this is relevant any longer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some apps don't use sprockets and the current set of initializers assumes sprockets to be loaded. I think it would be reasonable to conditionally set initializers based on if
Sprocketsis defined or not. This should be done before the gem is required in sprockets railtie that rails loads with "rails/all":https://github.com/rails/rails/blob/13a714f30d5e4c4a53062bb1b29fbeb287efd3be/railties/lib/rails/all.rb#L18
https://github.com/rails/sprockets-rails/blob/118ce60b1ffeb7a85640661b014cd2ee3c4e3e56/lib/sprockets/railtie.rb#L6
Also, the first commit is to clean up the mimemagic reference in the lockfile.