Skip to content

Conversation

@andresgutgon
Copy link
Contributor

What?

Address this comment #80 (comment)

Copy link
Contributor

@dixpac dixpac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is 👍, not sure about the default_files_with_class_names name in this scenario.

But, @dhh has the last word :)

@dhh
Copy link
Member

dhh commented Oct 12, 2021

Actually, let's turn this into a setting, so you can tweak it.

@dhh
Copy link
Member

dhh commented Oct 12, 2021

This is what #74 was trying to do.

@andresgutgon
Copy link
Contributor Author

Oh I think makes a lot of sense as a config, should we close this PR?

@dhh
Copy link
Member

dhh commented Oct 12, 2021

Think the other PR stalled. So feel free to finish it here first.

@dixpac
Copy link
Contributor

dixpac commented Dec 17, 2021

Same as #74 (comment)

@dhh dhh closed this Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants