Skip to content

Generator: Mailer and styles #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Conversation

dixpac
Copy link
Contributor

@dixpac dixpac commented Oct 13, 2021

Testing only mailer wasn't working from the default rails generators, so
this PR adds mailer also.

Also, fixes pointer on the submit button and small fix on controller h1
style to match the one from the scaffold index.

Testing only mailer wasn't working from the default rails generators, so
this PR adds mailer also.

Also, fixes pointer on the submit button and small fix on controller h1
style to match the one from the scaffold index.
@dixpac
Copy link
Contributor Author

dixpac commented Oct 13, 2021

@dhh I know we talked about splitting, because I'm a bit stubborn :) and until possible split only generator that raised error was mailer so this fixes it.

I've tried all rails default generators and they seem to work fine:

Screenshot 2021-10-13 at 19 15 03

Screenshot 2021-10-13 at 19 15 11

Screenshot 2021-10-13 at 19 15 36

Screenshot 2021-10-13 at 19 15 53

Screenshot 2021-10-13 at 19 16 38

Screenshot 2021-10-13 at 19 18 25

Tried also with rspec just in case, works fine also.

View component gem is another issue, as it stands we will need to contribute to view_component to support tailwindcss template_engine.

@dhh dhh merged commit c3177f4 into rails:main Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants