Add support for Rails 5. #89
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Giving this another go, since I need this in order to add tailwindcss generator for the `view_component`. View component is `rails >= 5`
|
@dhh I have opened the PR on view_components that fixes the issue with ( So, if you think that supporting rails 5 makes sense, merge and deploy(🙏🏼 ) than I can finish the work on |
|
@dhh pinging 😄 |
|
I'm not really keen on supporting Rails 5. I don't think we need to support the same as view_component does. We can still make the two compatible. |
|
Me neither. There is possibility to generate components wihtout the problem like this: Main thing here ViewComponent/view_component#1098 is that view_component depends on rails 5 in their tests. I'm closing this then, I will try to find the other way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Giving this another go, since we need this in order to add tailwindcss generator for the
view_component.View component is
rails >= 5