Add actionmailer test dependency to fix test suite #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test suite was failing with: ``` /home/runner/work/tailwindcss-rails/tailwindcss-rails/vendor/bundle/ruby/2.7.0/gems/activesupport-6.1.4.1/lib/active_support/dependencies.rb:332:in `require': cannot load such file -- rails/generators/mailer/mailer_generator (LoadError) from /home/runner/work/tailwindcss-rails/tailwindcss-rails/vendor/bundle/ruby/2.7.0/gems/activesupport-6.1.4.1/lib/active_support/dependencies.rb:332:in `block in require' from /home/runner/work/tailwindcss-rails/tailwindcss-rails/vendor/bundle/ruby/2.7.0/gems/activesupport-6.1.4.1/lib/active_support/dependencies.rb:299:in `load_dependency' from /home/runner/work/tailwindcss-rails/tailwindcss-rails/vendor/bundle/ruby/2.7.0/gems/activesupport-6.1.4.1/lib/active_support/dependencies.rb:332:in `require' from /home/runner/work/tailwindcss-rails/tailwindcss-rails/test/lib/generators/tailwindcss/mailer_generator_test.rb:2:in `<top (required)>' from /home/runner/work/tailwindcss-rails/tailwindcss-rails/vendor/bundle/ruby/2.7.0/gems/activesupport-6.1.4.1/lib/active_support/dependencies.rb:332:in `require' from /home/runner/work/tailwindcss-rails/tailwindcss-rails/vendor/bundle/ruby/2.7.0/gems/activesupport-6.1.4.1/lib/active_support/dependencies.rb:332:in `block in require' from /home/runner/work/tailwindcss-rails/tailwindcss-rails/vendor/bundle/ruby/2.7.0/gems/activesupport-6.1.4.1/lib/active_support/dependencies.rb:299:in `load_dependency' from /home/runner/work/tailwindcss-rails/tailwindcss-rails/vendor/bundle/ruby/2.7.0/gems/activesupport-6.1.4.1/lib/active_support/dependencies.rb:332:in `require' from /home/runner/work/tailwindcss-rails/tailwindcss-rails/vendor/bundle/ruby/2.7.0/gems/railties-6.1.4.1/lib/rails/test_unit/runner.rb:50:in `block in load_tests' from /home/runner/work/tailwindcss-rails/tailwindcss-rails/vendor/bundle/ruby/2.7.0/gems/railties-6.1.4.1/lib/rails/test_unit/runner.rb:50:in `each' from /home/runner/work/tailwindcss-rails/tailwindcss-rails/vendor/bundle/ruby/2.7.0/gems/railties-6.1.4.1/lib/rails/test_unit/runner.rb:50:in `load_tests' from /home/runner/work/tailwindcss-rails/tailwindcss-rails/vendor/bundle/ruby/2.7.0/gems/railties-6.1.4.1/lib/rails/test_unit/runner.rb:39:in `run' from /home/runner/work/tailwindcss-rails/tailwindcss-rails/vendor/bundle/ruby/2.7.0/gems/railties-6.1.4.1/lib/rails/plugin/test.rb:9:in `<top (required)>' from bin/test:5:in `require' from bin/test:5:in `<main>' Error: Process completed with exit code 1. ``` https://github.com/rails/tailwindcss-rails/runs/4413788255?check_suite_focus=true#step:4:4 This was caused by 1233c7a which replaced the dependency on `rails` with a dependency on `railties`. As a result, `actionmailer` was no longer being installed, but `test/lib/generators/tailwindcss/mailer_generator_test.rb` requires `rails/generators/mailer/mailer_generator` which is provided by `actionmailer`: https://github.com/rails/rails/blob/90357af08048ef5076730505f6e7b14a81f33d0c/actionmailer/lib/rails/generators/mailer/mailer_generator.rb Thus, we need `actionmailer` to be installed in order to run that test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test suite was failing with:
https://github.com/rails/tailwindcss-rails/runs/4413788255?check_suite_focus=true#step:4:4
This was caused by 1233c7a which replaced the dependency on
railswith a dependency onrailties. As a result,actionmailerwas no longer being installed, but this line depends onactionmailer:tailwindcss-rails/test/lib/generators/tailwindcss/mailer_generator_test.rb
Line 2 in b33f034
since
rails/generators/mailer/mailer_generatoris provided byactionmailer.Thus, we need
actionmailerto be installed in order to run that test.