Skip to content

Prevent massive POST requests to error_url if error_url is down#15

Merged
remybach merged 4 commits intoremybach:masterfrom
sweh:master
Nov 1, 2016
Merged

Prevent massive POST requests to error_url if error_url is down#15
remybach merged 4 commits intoremybach:masterfrom
sweh:master

Conversation

@sweh
Copy link
Contributor

@sweh sweh commented Oct 10, 2016

If the URL, the client tries to submit the error to (error_url), is down, the plugin will try to send that error again and again to the server.

This fix prevents that.

I also changed the indentation from TAB to SPACE.

@remybach
Copy link
Owner

Hey, thanks for taking the time to actually submit a PR!

If I could please just request that you remove the commit changing the indentation? It's generally not good practice to push something as opinionated as that into someone else's repo. It also makes the PR diff impossible to read (not so difficult in this case as there's just one other commit, but in bigger PRs it can be a nightmare).

Also: could you take care of the case where what is an object (the other side of this if statement)?

@sweh
Copy link
Contributor Author

sweh commented Nov 1, 2016

Hi remybach,

I readded the tab indentation, so the real change is now more clear to review.

I was not able to reproduce the problem, if what is an object, so I suppose this side of the if statements does not need a fix.

Kind regards,
Sebastian

@remybach
Copy link
Owner

remybach commented Nov 1, 2016

Great, thanks again @sweh!

@remybach remybach merged commit 25b7bc7 into remybach:master Nov 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants