Skip to content

Fix Google CDN jQuery links (missed .js) #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix Google CDN jQuery links (missed .js) #4

wants to merge 1 commit into from

Conversation

eagl3s1ght
Copy link

No description provided.

@karlwestin
Copy link
Member

Hi there!
This patch does not look necessary to me, to clarify: what's needed in the config is not a direct path, but a require.js module name.
Are you having trouble making the demo work as it is now? (see here: https://github.com/requirejs/example-jquery-cdn/blob/master/www/js/app.js) Run node tools/server.js and go to http://localhost:8888/www/app.html. If this does not work, please report what browser and if you get an error message in the console.

Thanks!

@eagl3s1ght
Copy link
Author

Hi,

It may have been a slightly uneducated proposal. I was actually creating a userscript and noticed it.
Sorry! I guess it was a long shot that it would have been a typo.

@karlwestin
Copy link
Member

:)
It can be a little confusing with requirejs paths versus urls. Especially since, in this case, both would work.
If you wanna read more about paths, this is a good starting point: http://requirejs.org/docs/1.0/docs/api.html#jsfiles

@karlwestin karlwestin closed this Dec 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants