Fix IE8 errors. Closes #45 #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| '\u2004\u2005\u2006\u2007\u2008\u2009\u200A\u202F\u205F\u3000\u2028' + | ||
| '\u2029\uFEFF'; | ||
|
|
||
| if (!String.prototype.trim || ws.trim()) { |
There was a problem hiding this comment.
hmm this seems a bit extreme, I'd just do str.replace(/^\s+|\s+$/g, '') with no fallback on the native one, regexps are plenty fast
There was a problem hiding this comment.
Okay :) Shall I fix this or will you do it?
There was a problem hiding this comment.
I replaced it now with the regex given. To not get a function call overhead I didn't wrap the regex in a trim function.
|
I wouldn't worry about the function overhead, you can typically invoke a function ~5,000,000+ times a second which is plenty haha but good enough :D thanks! |
|
Haha okay! I guess I let some SO answer impact me too much regarding function overheads :p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.