Parser now correctly parses attributes with whitespace before colon #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@visionmedia +1 |
| @@ -181,7 +181,7 @@ module.exports = function(css, options){ | |||
| // prop | |||
| var prop = match(/^(\*?[-\/\*\w]+)\s*/); | |||
| if (!prop) return; | |||
| prop = prop[0]; | |||
| prop = prop[0].replace(/^\s+|\s+$/, ''); | |||
|
LGTM, just that tiny thing I'll fix |
tj
added a commit
that referenced
this pull request
Sep 10, 2013
Parser now correctly parses attributes with whitespace before colon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For rules such as:
... that contain whitespace before a colon, the CSS attribute name is extracted with the whitespace instead of trimming it. This breaks the case above, which is valid CSS. The added test case and modified expected result are contained in the pull request, including the trimming in
index.js.This is a fix I need to fix autoprefixer, which depends on this library for parsing CSS files and applying prefixes where applicable.