Performance improvements to atrule() and trim() fns #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i would pull the however, the |
|
Ah, good point about |
|
|
Before this change, `atrule()` was a cascade of potentially failing RegExps. This change introduces a short-circuit that bypasses the RegExps if the next character is not an '@'. `make bench` shows a 20-25% improvement in op/s. Also before this change, when the argument is falsy `trim()` calls `replace()` on the empty string. This change guards against unnecessary calls to `replace()` with a ternary. `make bench` shows a 2.5-5.5% improvement in op/s. With both changes, make bench shows a combined 30-40% improvement. Benchmarks were run 5 times and the results averaged.
|
cool thanks! |
tj
added a commit
that referenced
this pull request
Oct 23, 2013
Performance improvements to atrule() and trim() fns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a couple tiny (code-wise) perf tweaks with a big impact today.
Before this change,
atrule()was a cascade of potentially failing RegExps.This change introduces a short-circuit that bypasses the RegExps if the
next character is not an '@'.
make benchshows a 20-25% improvement inop/s.
Also before this change, when the argument is falsy
trim()callsreplace()on the empty string. This change guards against unnecessary calls to
replace()with a ternary.
make benchshows a 2.5-5.5% improvement in op/s.With both changes, make bench shows a combined 30-40% improvement.
Benchmarks were run 5 times and the results averaged.