Skip to content

fixed parsing error when input broken comments #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

rhiokim
Copy link

@rhiokim rhiokim commented Jan 17, 2014

String.prototyp.charAt do not return Null.
Return char(String) or empty string ""

var css = require('css');
css.parse('/* comments'); // While loop can not stop

@jonathanong
Copy link
Contributor

can you add a test?

@rhiokim
Copy link
Author

rhiokim commented Jan 17, 2014

@jonathanong yep! sure :-)

@jonathanong
Copy link
Contributor

will you be adding a test?

@jonathanKingston
Copy link
Contributor

@rhiokim I only noticed this after I was ready to push the fix... I wasn't trying to step on your toes at all. Thanks for all the great work guys.

jonathanong added a commit that referenced this pull request Feb 28, 2014
Fixes CSS parsing error, throws an end of comment issue. fixes #69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants