Skip to content

Add support for @font-face, which should not be considered a selector #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2014

Conversation

ericf
Copy link
Contributor

@ericf ericf commented Mar 12, 2014

This change parses @font-face rules as an at-rule, instead of treating them as a standard rule with @font-face being the selector.

This change parses `@font-face` rules as an at-rule, instead of treating them as a standard rule with `@font-face` being the selector.
ericf added a commit to ericf/css-stringify that referenced this pull request Mar 12, 2014
This change stringifies `@font-face` at-rules, instead of treating them as a standard rule with `@font-face` being the selector.

Relates reworkcss/css-parse#75
@jonathanong
Copy link
Contributor

gah don't like special-casing every single @ statement. should be a better solution to this but i don't know enough about parsers to do it.

@tj
Copy link
Member

tj commented Mar 23, 2014

many of them have completely different semantics, we'd have to at least hard-code which atrule map to what type of body etc, I'd be fine with that but it's not hard either way

tj added a commit that referenced this pull request Mar 23, 2014
Add support for @font-face, which should not be considered a selector
@tj tj merged commit aa7e232 into reworkcss:master Mar 23, 2014
@ericf
Copy link
Contributor Author

ericf commented Mar 23, 2014

Thanks for merging this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants