Skip to content

Parse attribute selectors with comma #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2014
Merged

Conversation

marcelduran
Copy link
Contributor

Fixed selector parser to parse attribute selectors with/without comma properly.
Test included.

@marcelduran
Copy link
Contributor Author

e.g.:

img[src^="data:image/png;base64,"], img[src^="data:image/jpeg;base64,"] {/*...*/}

is currently parsed as

  • img[src^="data:image/png;base64
  • "]
  • img[src^="data:image/jpeg;base64
  • "]

when the expected parsed results should be:

  • img[src^="data:image/png;base64,"]
  • img[src^="data:image/jpeg;base64,"]

necolas added a commit that referenced this pull request May 16, 2014
Parse attribute selectors with comma
@necolas necolas merged commit b5b5e38 into reworkcss:master May 16, 2014
@necolas
Copy link
Contributor

necolas commented May 16, 2014

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants