Embed source file content in source map #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depends on latest css-stringify git master
necolas
added a commit
that referenced
this pull request
May 28, 2014
Embed source file content in source map
| @@ -62,13 +64,15 @@ exports.emit = function(str, pos, startOnly) { | |||
| column: pos.start.column - 1 | |||
| } | |||
| }); | |||
|
|
|||
| this.map.setSourceContent(sourceFile, pos.content || ''); | |||
There was a problem hiding this comment.
Isn’t it better to:
if (pos.content) {
this.map.setSourceContent(sourceFile, pos.content);
}There’s nothing wrong with setting source content just for a few sources. The rest could be fetched by a browser’s developer tools, for example.
conradz
added a commit
that referenced
this pull request
Jun 2, 2014
Somehow these had been added in #33 but lost in a later merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on latest (currently unreleased) css-parse git master.
This adds the source file contents to the source map, like browserify and most other bundling tools do. Browser dev tools no longer have to access the original source files over HTTP, they can just pull them out of the source map.