[Critical Bug] dynamically assign isOverPanel to reduce mistaken mousewheel captures#122
Merged
rochal merged 1 commit intorochal:masterfrom Aug 31, 2014
Merged
Conversation
rochal
added a commit
that referenced
this pull request
Aug 31, 2014
[Critical Bug] dynamically assign isOverPanel to reduce mistaken mousewheel captures
|
This fork introduced another bug as I detailed in this topic. Not sure what's the solution for your case, but I had to remove part of your code to make it work properly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that slimScroll was causing my mousewheel behaviour to break (become completely inoperable) occasionally.
Steps to replicate:
Expect:
Get:
The cause:
This pull request suggests changing isOverPanel to a simple function that gets assessed at the time it is needed, to avoid false assignments.