Fixed scrolling issues with un-released scroll after destroying slimScroll#130
Open
bacbos wants to merge 1 commit intorochal:masterfrom
Open
Fixed scrolling issues with un-released scroll after destroying slimScroll#130bacbos wants to merge 1 commit intorochal:masterfrom
bacbos wants to merge 1 commit intorochal:masterfrom
Conversation
|
Not working either. Tested in this demo I added the detach function for the wheel event as well,suggested in other topics. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In collaboration with @sopinon :)
When destroying slimScroll while releaseScroll is still set to false, issues with the mouse wheel can occur under certain conditions.
This patch fixes this by making sure that slimScroll releases scroll at all times before destroying itself.