bar.css('top') instead of bar.position().top#7
Merged
rochal merged 1 commit intorochal:masterfrom Dec 3, 2011
robink:master
Merged
bar.css('top') instead of bar.position().top#7rochal merged 1 commit intorochal:masterfrom robink:master
rochal merged 1 commit intorochal:masterfrom
robink:master
Conversation
Owner
|
thanks! I'll review asap |
rochal
added a commit
that referenced
this pull request
Dec 3, 2011
bar.css('top') instead of bar.position().top
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As seen on http://api.jquery.com/position/ , position() is not working with hidden elements
This induce a bug that you can reproduce this way:
1/ go to a scrollable area, scroll to the middle of it
2/ stop scrolling with still having the cursor in the scrollable area, do not move the mouse anymore
3/ wait for the scrollbar to disappear
4/ scroll again, still without moving the cursor
Scroll should go to top.
This is fixed by the following pull request.