Convert upload to kotlin (part 1) (commons-app#6024)

* Convert upload dagger module to kotlin

* Code cleanup and convert the upload contract to kotlin

* Code cleanup and convert CategoriesContract to kotlin

* Code cleanup and convert MediaLicenseContract to kotlin

* Code cleanup and convert UploadMediaDetailsContract to kotlin

* Code cleanup, fixed nullability and converted DepictsContract to kotlin

* Removed unused class

* Convert FileMetadataUtils to kotlin

* Convert EXIFReader to kotlin

* Convert FileUtils to kotlin

* Convert FileUtilsWrapper to kotlin

* Convert ImageProcessingService to kotlin

* Convert PageContentsCreator to kotlin

* Convert PendingUploadsPresenter and contract to Kotlin with some code-cleanup

* Convert ReadFBMD to kotlin

* Convert SimilarImageInterface to kotlin

* Removed unused classes

* Fix merge/rebase issue

---------

Co-authored-by: Nicolas Raoul <nicolas.raoul@gmail.com>

Author: psh

app/src/main/java/fr/free/nrw/commons/di/CommonsApplicationModule.kt

@@ -29,6 +29,7 @@ import fr.free.nrw.commons.settings.Prefs
 import fr.free.nrw.commons.upload.UploadController
 import fr.free.nrw.commons.upload.depicts.DepictsDao
 import fr.free.nrw.commons.utils.ConfigUtils.isBetaFlavour
+import fr.free.nrw.commons.utils.TimeProvider
 import fr.free.nrw.commons.wikidata.WikidataEditListener
 import fr.free.nrw.commons.wikidata.WikidataEditListenerImpl
 import io.reactivex.Scheduler
@@ -224,6 +225,11 @@ open class CommonsApplicationModule(private val applicationContext: Context) {
     fun providesContentResolver(context: Context): ContentResolver =
         context.contentResolver
 
+    @Provides
+    fun provideTimeProvider(): TimeProvider {
+        return TimeProvider(System::currentTimeMillis)
+    }
+
     companion object {
         const val IO_THREAD: String = "io_thread"
         const val MAIN_THREAD: String = "main_thread"

app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.java

@@ -528,7 +528,9 @@ public boolean onZoom(ZoomEvent event) {
             final Bundle bundle = new Bundle();
             try {
                 bundle.putString("query",
-                    FileUtils.readFromResource("/queries/radius_query_for_upload_wizard.rq"));
+                    FileUtils.INSTANCE.readFromResource(
+                        "/queries/radius_query_for_upload_wizard.rq")
+                );
             } catch (IOException e) {
                 Timber.e(e);
             }

app/src/main/java/fr/free/nrw/commons/upload/EXIFReader.java

@@ -0,0 +1,31 @@
+package fr.free.nrw.commons.upload
+
+import androidx.exifinterface.media.ExifInterface
+import androidx.exifinterface.media.ExifInterface.TAG_DATETIME
+import androidx.exifinterface.media.ExifInterface.TAG_MAKE
+import fr.free.nrw.commons.utils.ImageUtils.FILE_NO_EXIF
+import fr.free.nrw.commons.utils.ImageUtils.IMAGE_OK
+import io.reactivex.Single
+import javax.inject.Inject
+import javax.inject.Singleton
+
+/**
+ * We try to minimize uploads from the Commons app that might be copyright violations.
+ * If an image does not have any Exif metadata, then it was likely downloaded from the internet,
+ * and is probably not an original work by the user. We detect these kinds of images by looking
+ * for the presence of some basic Exif metadata.
+ */
+@Singleton
+class EXIFReader @Inject constructor() {
+    fun processMetadata(path: String): Single<Int> = Single.just(
+        try {
+            if (ExifInterface(path).hasMakeOrDate) IMAGE_OK else FILE_NO_EXIF
+        } catch (e: Exception) {
+            FILE_NO_EXIF
+        }
+    )
+
+    private val ExifInterface.hasMakeOrDate get() =
+        getAttribute(TAG_MAKE) != null || getAttribute(TAG_DATETIME) != null
+}
+

app/src/main/java/fr/free/nrw/commons/upload/EXIFReader.kt

@@ -10,6 +10,7 @@ import androidx.recyclerview.widget.LinearLayoutManager
 import fr.free.nrw.commons.R
 import fr.free.nrw.commons.auth.SessionManager
 import fr.free.nrw.commons.contributions.Contribution
+import fr.free.nrw.commons.contributions.Contribution.Companion.STATE_FAILED
 import fr.free.nrw.commons.databinding.FragmentFailedUploadsBinding
 import fr.free.nrw.commons.di.CommonsDaggerSupportFragment
 import fr.free.nrw.commons.media.MediaClient
@@ -43,7 +44,7 @@ class FailedUploadsFragment :
 
     private lateinit var adapter: FailedUploadsAdapter
 
-    var contributionsList = ArrayList<Contribution>()
+    var contributionsList = mutableListOf<Contribution>()
 
     private lateinit var uploadProgressActivity: UploadProgressActivity
 
@@ -71,7 +72,7 @@ class FailedUploadsFragment :
         inflater: LayoutInflater,
         container: ViewGroup?,
         savedInstanceState: Bundle?,
-    ): View? {
+    ): View {
         binding = FragmentFailedUploadsBinding.inflate(layoutInflater)
         pendingUploadsPresenter.onAttachView(this)
         initAdapter()
@@ -99,9 +100,9 @@ class FailedUploadsFragment :
         pendingUploadsPresenter.getFailedContributions()
         pendingUploadsPresenter.failedContributionList.observe(
             viewLifecycleOwner,
-        ) { list: PagedList<Contribution?> ->
+        ) { list: PagedList<Contribution> ->
             adapter.submitList(list)
-            contributionsList = ArrayList()
+            contributionsList = mutableListOf()
             list.forEach {
                 if (it != null) {
                     contributionsList.add(it)
@@ -124,26 +125,22 @@ class FailedUploadsFragment :
      * Restarts all the failed uploads.
      */
     fun restartUploads() {
-        if (contributionsList != null) {
-            pendingUploadsPresenter.restartUploads(
-                contributionsList,
-                0,
-                this.requireContext().applicationContext,
-            )
-        }
+        pendingUploadsPresenter.restartUploads(
+            contributionsList,
+            0,
+            requireContext().applicationContext,
+        )
     }
 
     /**
      * Restarts a specific upload.
      */
     override fun restartUpload(index: Int) {
-        if (contributionsList != null) {
-            pendingUploadsPresenter.restartUpload(
-                contributionsList,
-                index,
-                this.requireContext().applicationContext,
-            )
-        }
+        pendingUploadsPresenter.restartUpload(
+            contributionsList,
+            index,
+            requireContext().applicationContext,
+        )
     }
 
     /**
@@ -166,7 +163,7 @@ class FailedUploadsFragment :
                 ViewUtil.showShortToast(context, R.string.cancelling_upload)
                 pendingUploadsPresenter.deleteUpload(
                     contribution,
-                    this.requireContext().applicationContext,
+                    requireContext().applicationContext,
                 )
             },
             {},
@@ -177,28 +174,24 @@ class FailedUploadsFragment :
      * Deletes all the uploads after getting a confirmation from the user using Dialog.
      */
     fun deleteUploads() {
-        if (contributionsList != null) {
-            DialogUtil.showAlertDialog(
-                requireActivity(),
-                String.format(
-                    Locale.getDefault(),
-                    requireActivity().getString(R.string.cancelling_all_the_uploads),
-                ),
-                String.format(
-                    Locale.getDefault(),
-                    requireActivity().getString(R.string.are_you_sure_that_you_want_cancel_all_the_uploads),
-                ),
-                String.format(Locale.getDefault(), requireActivity().getString(R.string.yes)),
-                String.format(Locale.getDefault(), requireActivity().getString(R.string.no)),
-                {
-                    ViewUtil.showShortToast(context, R.string.cancelling_upload)
-                    uploadProgressActivity.hidePendingIcons()
-                    pendingUploadsPresenter.deleteUploads(
-                        listOf(Contribution.STATE_FAILED),
-                    )
-                },
-                {},
-            )
-        }
+        DialogUtil.showAlertDialog(
+            requireActivity(),
+            String.format(
+                Locale.getDefault(),
+                requireActivity().getString(R.string.cancelling_all_the_uploads),
+            ),
+            String.format(
+                Locale.getDefault(),
+                requireActivity().getString(R.string.are_you_sure_that_you_want_cancel_all_the_uploads),
+            ),
+            String.format(Locale.getDefault(), requireActivity().getString(R.string.yes)),
+            String.format(Locale.getDefault(), requireActivity().getString(R.string.no)),
+            {
+                ViewUtil.showShortToast(context, R.string.cancelling_upload)
+                uploadProgressActivity.hidePendingIcons()
+                pendingUploadsPresenter.deleteUploads(listOf(STATE_FAILED))
+            },
+            {},
+        )
     }
 }

app/src/main/java/fr/free/nrw/commons/upload/FailedUploadsFragment.kt

@@ -0,0 +1,61 @@
+package fr.free.nrw.commons.upload
+
+import androidx.exifinterface.media.ExifInterface
+import timber.log.Timber
+
+/**
+ * Support utils for EXIF metadata handling
+ *
+ */
+object FileMetadataUtils {
+    /**
+     * Takes EXIF label from sharedPreferences as input and returns relevant EXIF tags
+     *
+     * @param pref EXIF sharedPreference label
+     * @return EXIF tags
+     */
+    fun getTagsFromPref(pref: String): Array<String> {
+        Timber.d("Retuning tags for pref:%s", pref)
+        return when (pref) {
+            "Author" -> arrayOf(
+                ExifInterface.TAG_ARTIST,
+                ExifInterface.TAG_CAMERA_OWNER_NAME
+            )
+
+            "Copyright" -> arrayOf(
+                ExifInterface.TAG_COPYRIGHT
+            )
+
+            "Location" -> arrayOf(
+                ExifInterface.TAG_GPS_LATITUDE,
+                ExifInterface.TAG_GPS_LATITUDE_REF,
+                ExifInterface.TAG_GPS_LONGITUDE,
+                ExifInterface.TAG_GPS_LONGITUDE_REF,
+                ExifInterface.TAG_GPS_ALTITUDE,
+                ExifInterface.TAG_GPS_ALTITUDE_REF
+            )
+
+            "Camera Model" -> arrayOf(
+                ExifInterface.TAG_MAKE,
+                ExifInterface.TAG_MODEL
+            )
+
+            "Lens Model" -> arrayOf(
+                ExifInterface.TAG_LENS_MAKE,
+                ExifInterface.TAG_LENS_MODEL,
+                ExifInterface.TAG_LENS_SPECIFICATION
+            )
+
+            "Serial Numbers" -> arrayOf(
+                ExifInterface.TAG_BODY_SERIAL_NUMBER,
+                ExifInterface.TAG_LENS_SERIAL_NUMBER
+            )
+
+            "Software" -> arrayOf(
+                ExifInterface.TAG_SOFTWARE
+            )
+
+            else -> arrayOf()
+        }
+    }
+}