Skip to content

Commit 6fd9696

Browse files
dbrantneslihanturan
authored andcommitted
Remove additional unnecessary dependencies. (commons-app#2948)
1 parent 967d3ea commit 6fd9696

File tree

9 files changed

+9
-26
lines changed

9 files changed

+9
-26
lines changed

app/build.gradle

-3
Original file line numberDiff line numberDiff line change
@@ -77,14 +77,11 @@ dependencies {
7777
androidTestUtil 'androidx.test:orchestrator:1.1.1'
7878

7979
// Debugging
80-
implementation 'com.facebook.stetho:stetho:1.5.0'
8180
debugImplementation "com.squareup.leakcanary:leakcanary-android:$LEAK_CANARY_VERSION"
8281
releaseImplementation "com.squareup.leakcanary:leakcanary-android-no-op:$LEAK_CANARY_VERSION"
8382
testImplementation "com.squareup.leakcanary:leakcanary-android-no-op:$LEAK_CANARY_VERSION"
8483

8584
// Support libraries
86-
implementation "androidx.legacy:legacy-support-v4:1.0.0"
87-
implementation "androidx.appcompat:appcompat:1.0.2"
8885
implementation "com.google.android.material:material:1.1.0-alpha04"
8986
implementation "androidx.browser:browser:1.0.0"
9087
implementation "androidx.cardview:cardview:1.0.0"

app/src/main/java/fr/free/nrw/commons/CommonsApplication.java

-5
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212

1313
import com.facebook.drawee.backends.pipeline.Fresco;
1414
import com.facebook.imagepipeline.core.ImagePipelineConfig;
15-
import com.facebook.stetho.Stetho;
1615
import com.squareup.leakcanary.LeakCanary;
1716
import com.squareup.leakcanary.RefWatcher;
1817

@@ -143,10 +142,6 @@ public void onCreate() {
143142
// TODO: Remove when we're able to initialize Fresco in test builds.
144143
}
145144

146-
if (BuildConfig.DEBUG && !isRoboUnitTest()) {
147-
Stetho.initializeWithDefaults(this);
148-
}
149-
150145
createNotificationChannel(this);
151146

152147
languageLookUpTable = new AppLanguageLookUpTable(this);

app/src/main/java/fr/free/nrw/commons/auth/SessionManager.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@
77
import android.content.Context;
88
import android.os.Bundle;
99

10-
import javax.annotation.Nullable;
10+
import androidx.annotation.Nullable;
11+
1112
import javax.inject.Inject;
1213
import javax.inject.Named;
1314
import javax.inject.Singleton;

app/src/main/java/fr/free/nrw/commons/category/CategoryImageUtils.java

-9
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,13 @@
11
package fr.free.nrw.commons.category;
22

3-
import androidx.annotation.NonNull;
4-
5-
import org.apache.commons.lang3.StringUtils;
63
import org.w3c.dom.Element;
74
import org.w3c.dom.Node;
85
import org.w3c.dom.NodeList;
9-
import org.wikipedia.util.StringUtil;
106

117
import java.util.ArrayList;
128
import java.util.Collections;
139
import java.util.List;
1410

15-
import javax.annotation.Nullable;
16-
17-
import fr.free.nrw.commons.Media;
18-
import timber.log.Timber;
19-
2011
public class CategoryImageUtils {
2112

2213
/**

app/src/main/java/fr/free/nrw/commons/filepicker/UploadableFile.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@
66
import android.os.Parcel;
77
import android.os.Parcelable;
88

9+
import androidx.annotation.Nullable;
10+
911
import com.drew.imaging.ImageMetadataReader;
1012
import com.drew.imaging.ImageProcessingException;
1113
import com.drew.metadata.Metadata;
@@ -15,8 +17,6 @@
1517
import java.io.IOException;
1618
import java.util.Date;
1719

18-
import javax.annotation.Nullable;
19-
2020
import fr.free.nrw.commons.upload.FileUtils;
2121

2222
public class UploadableFile implements Parcelable {

app/src/main/java/fr/free/nrw/commons/kvstore/JsonKvStore.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,15 @@
22

33
import android.content.Context;
44

5+
import androidx.annotation.Nullable;
6+
57
import com.google.gson.Gson;
68
import com.google.gson.JsonSyntaxException;
79

810
import java.lang.reflect.Type;
911
import java.util.HashMap;
1012
import java.util.Map;
1113

12-
import javax.annotation.Nullable;
13-
1414
public class JsonKvStore extends BasicKvStore {
1515
private final Gson gson;
1616

app/src/main/java/fr/free/nrw/commons/notification/NotificationUtils.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import android.annotation.SuppressLint;
44
import android.content.Context;
55
import androidx.annotation.NonNull;
6+
import androidx.annotation.Nullable;
67

78
import org.w3c.dom.Element;
89
import org.w3c.dom.Node;
@@ -11,8 +12,6 @@
1112
import java.util.ArrayList;
1213
import java.util.List;
1314

14-
import javax.annotation.Nullable;
15-
1615
import fr.free.nrw.commons.BuildConfig;
1716
import fr.free.nrw.commons.R;
1817

app/src/main/java/fr/free/nrw/commons/review/ReviewHelper.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@
66
import java.util.List;
77
import java.util.Random;
88

9-
import javax.annotation.Nullable;
109
import javax.inject.Inject;
1110
import javax.inject.Singleton;
1211

12+
import androidx.annotation.Nullable;
1313
import androidx.core.util.Pair;
1414
import fr.free.nrw.commons.Media;
1515
import fr.free.nrw.commons.mwapi.MediaWikiApi;

app/src/main/java/fr/free/nrw/commons/utils/NetworkUtils.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
import android.net.NetworkInfo;
88
import android.telephony.TelephonyManager;
99

10-
import javax.annotation.Nullable;
10+
import androidx.annotation.Nullable;
1111

1212
import fr.free.nrw.commons.utils.model.NetworkConnectionType;
1313

0 commit comments

Comments
 (0)