Skip to content

Conversation

@dbrant
Copy link
Collaborator

@dbrant dbrant commented May 14, 2019

This removes the dependencies on androidx.legacy and androidx.appcompat which are not used at all.

This also removes the dependency on the Facebook Stetho library, which is apparently a debug bridge for operating with Chrome dev tools. Do you use this? If so, how is it better than using the Android Studio debug tools?

A side effect of removing these dependencies is the correct usage of Nullable and NonNull annotations from androidx instead of javax.

@codecov-io
Copy link

Codecov Report

Merging #2948 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2948      +/-   ##
=========================================
+ Coverage    3.69%   3.69%   +<.01%     
=========================================
  Files         247     247              
  Lines       12217   12215       -2     
  Branches     1083    1082       -1     
=========================================
  Hits          451     451              
+ Misses      11732   11730       -2     
  Partials       34      34
Impacted Files Coverage Δ
.../java/fr/free/nrw/commons/review/ReviewHelper.java 86.48% <ø> (ø) ⬆️
...n/java/fr/free/nrw/commons/CommonsApplication.java 0% <ø> (ø) ⬆️
.../free/nrw/commons/category/CategoryImageUtils.java 0% <ø> (ø) ⬆️
.../java/fr/free/nrw/commons/auth/SessionManager.java 0% <ø> (ø) ⬆️
...ee/nrw/commons/notification/NotificationUtils.java 0% <ø> (ø) ⬆️
...fr/free/nrw/commons/filepicker/UploadableFile.java 1.61% <ø> (ø) ⬆️
.../java/fr/free/nrw/commons/kvstore/JsonKvStore.java 0% <ø> (ø) ⬆️
...n/java/fr/free/nrw/commons/utils/NetworkUtils.java 72% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 967d3ea...72351c9. Read the comment docs.

@maskaravivek
Copy link
Contributor

This also removes the dependency on the Facebook Stetho library, which is apparently a debug bridge for operating with Chrome dev tools. Do you use this? If so, how is it better than using the Android Studio debug tools?

I use this frequently for checking the DB and shared prefs. I wasn't aware that that the same can be easily done using Android Studio Debug tools. Just read up a blog to see how it works. https://medium.com/@mattyskala/browse-sqlite-database-in-android-studio-4fbba6cca105

Am up for removing the library and start using Android debug tools for the same. :)

Copy link
Collaborator

@neslihanturan neslihanturan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dbrant !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants