Skip to content

Fixes translate(100px, undefinedpx), and transition transform#84

Closed
atotic wants to merge 3 commits intorstacruz:masterfrom
atotic:master
Closed

Fixes translate(100px, undefinedpx), and transition transform#84
atotic wants to merge 3 commits intorstacruz:masterfrom
atotic:master

Conversation

@atotic
Copy link
Contributor

@atotic atotic commented Oct 12, 2012

2 minor bug fixes:

css('translate' ,100) was setting
-moz-translate(100px, undefinedpx),
instead of
-moz-translate(100px, 0px)
causing css asignment to fail.

Problem was strict equality with null. Added check for undefined fixes the bug.

css('transition', 'transform 0.2s') was setting
-moz-transition transform 0.2s
instead of
-moz-transition MozTransform 0.2s
causing transition not to run at all.

Fix is to use prefixed properties as transition arguments.

Love the library! Thanks.

@atotic
Copy link
Contributor Author

atotic commented Oct 12, 2012

Only my 1st commit fixes the problems. The other 2 should not be part of this patch, and were comitted after the pull request. I am not sure how to remove them.

@rstacruz
Copy link
Owner

Hmm—in the first place, css('translate', 100) is not supposed to be valid, and neither shouldcss('translate', [100]). The use of$.cssProps` is rather brilliant though.

@rstacruz rstacruz closed this Dec 13, 2012
rstacruz added a commit that referenced this pull request Dec 13, 2012
@rstacruz
Copy link
Owner

I've cherry-picked your relevant commit out—it won't show up here as a merge (because it's not), but your fix should be in there scheduled for 1.0.0. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants